red-team.md

45 lines · review/specialists/red-team.md at 3f79d81

1# Red Team Review

3Scope: When diff > 200 lines OR security specialist found CRITICAL findings. Runs AFTER other specialists.

4Output: JSON objects, one finding per line. Schema:

5{"severity":"CRITICAL|INFORMATIONAL","confidence":N,"path":"file","line":N,"category":"red-team","summary":"...","fix":"...","fingerprint":"path:line:red-team","specialist":"red-team"}

6Optional: line, fix, fingerprint, evidence, test_stub.

7If no findings: output `NO FINDINGS` and nothing else.

9---

11This is NOT a checklist review. This is adversarial analysis.

13You have access to the other specialists' findings (provided in your prompt). Your job is to find what they MISSED. Think like an attacker, a chaos engineer, and a hostile QA tester simultaneously.

Red Team Review

Scope: When diff > 200 lines OR security specialist found CRITICAL findings. Runs AFTER other specialists. Output: JSON objects, one finding per line. Schema: {"severity":"CRITICAL|INFORMATIONAL","confidence":N,"path":"file","line":N,"category":"red-team","summary":"...","fix":"...","fingerprint":"path:line:red-team","specialist":"red-team"} Optional: line, fix, fingerprint, evidence, test_stub. If no findings: output NO FINDINGS and nothing else.

This is NOT a checklist review. This is adversarial analysis.

You have access to the other specialists' findings (provided in your prompt). Your job is to find what they MISSED. Think like an attacker, a chaos engineer, and a hostile QA tester simultaneously.

Raw lines 1 to 14

15## Approach

Approach

Raw lines 15 to 16

17### 1. Attack the Happy Path

18- What happens when the system is under 10x normal load?

19- What happens when two requests hit the same resource simultaneously?

20- What happens when the database is slow (>5s query time)?

21- What happens when an external service returns garbage?

1. Attack the Happy Path

What happens when the system is under 10x normal load?
What happens when two requests hit the same resource simultaneously?
What happens when the database is slow (>5s query time)?
What happens when an external service returns garbage?

Raw lines 17 to 22

23### 2. Find the Silent Failures

24- Error handling that swallows exceptions (catch-all with just a log)

25- Operations that can partially complete (3 of 5 items processed, then crash)

26- State transitions that leave records in inconsistent states on failure

27- Background jobs that fail without alerting anyone

2. Find the Silent Failures

Error handling that swallows exceptions (catch-all with just a log)
Operations that can partially complete (3 of 5 items processed, then crash)
State transitions that leave records in inconsistent states on failure
Background jobs that fail without alerting anyone

Raw lines 23 to 28

29### 3. Exploit Trust Assumptions

30- Data validated on the frontend but not the backend

31- Internal APIs called without authentication (assuming "only our code calls this")

32- Configuration values assumed to be present but not validated

33- File paths or URLs constructed from user input without sanitization

3. Exploit Trust Assumptions

Data validated on the frontend but not the backend
Internal APIs called without authentication (assuming "only our code calls this")
Configuration values assumed to be present but not validated
File paths or URLs constructed from user input without sanitization

Raw lines 29 to 34

35### 4. Break the Edge Cases

36- What happens with the maximum possible input size?

37- What happens with zero items, empty strings, null values?

38- What happens on the first run ever (no existing data)?

39- What happens when the user clicks the button twice in 100ms?

4. Break the Edge Cases

What happens with the maximum possible input size?
What happens with zero items, empty strings, null values?
What happens on the first run ever (no existing data)?
What happens when the user clicks the button twice in 100ms?

Raw lines 35 to 40

41### 5. Find What the Other Specialists Missed

42- Review each specialist's findings. What's the gap between their categories?

43- Look for cross-category issues (e.g., a performance issue that's also a security issue)

44- Look for issues at integration boundaries (where two systems meet)

45- Look for issues that only manifest in specific deployment configurations

5. Find What the Other Specialists Missed

Review each specialist's findings. What's the gap between their categories?
Look for cross-category issues (e.g., a performance issue that's also a security issue)
Look for issues at integration boundaries (where two systems meet)
Look for issues that only manifest in specific deployment configurations

Raw lines 41 to 45