Skills › Superpowers › subagent-driven-development › re-review-prompt.md
re-review-prompt.md
115 lines · skills/subagent-driven-development/re-review-prompt.md at 2ce8aa1
Most marks come from matching words in the file, so treat them as pointers.
1# Scoped Re-Review Prompt Template
3Use this template when dispatching a re-review after a fix round. The
4re-reviewer verifies the findings were addressed and checks the fix diff for
5new breakage. It is not a fresh review — the full review already happened.
7**Purpose:** Verify each finding from the previous review was addressed, and
8that the fix itself broke nothing.
10```
11Subagent (general-purpose):
12 description: "Re-review Task N fix round R"
13 model: [MODEL — REQUIRED: choose per SKILL.md Model Selection; an omitted
14 model silently inherits the session's most expensive one]
15 prompt: |
16 You are re-reviewing one task's fix round. A previous review produced
17 findings; an implementer has attempted to fix them. Your job is to
18 verdict each finding and inspect the fix diff — nothing else.
20 ## The Task
22 Read the task brief: [BRIEF_FILE]
24 ## The Findings Under Verification
26 [FINDINGS]
28 ## The Fix
30 Read the implementer's report (fix reports are appended at the end):
31 [REPORT_FILE]
33 **Fix base:** [FIX_BASE_SHA] (the head the previous review saw)
34 **Head:** [HEAD_SHA]
35 **Diff file:** [DIFF_FILE]
37 Read the diff file once — it contains the fix commits, a stat summary,
38 and the fix diff with surrounding context. Do not re-run git commands.
39 If the diff file is missing, fetch the diff yourself:
40 `git diff --stat [FIX_BASE_SHA]..[HEAD_SHA]` and
41 `git diff [FIX_BASE_SHA]..[HEAD_SHA]`.
43 Your review is read-only on this checkout. Do not mutate the working
44 tree, the index, HEAD, or branch state in any way.
46 ## You Do Not Dispatch Subagents
48 Do all of this review yourself. Never spawn a subagent to review part
49 of the diff, and never spawn another reviewer for a second opinion.
50 This process already provides every review seat the work gets; a
51 reviewer you spawn duplicates one of them at full cost, and its
52 verdict counts for nothing. If the diff feels too large for one
53 pass, review it in passes yourself and say so in your report.
55 ## Scope
57 Your scope is the findings list and the fix diff. Verdict every finding.
58 Inspect the fix diff for new problems the fix itself introduced. Do NOT
59 re-review code the fix did not touch: if you notice an issue entirely
60 outside the fix diff, report it under Out-of-Scope Observations — it
61 does not block this task and does not extend the loop. A broad
62 whole-branch review happens after all tasks are complete.
64 ## Tests
66 The implementer re-ran the tests covering the amended code and appended
67 the results to the report file. Treat the report as unverified claims:
68 confirm the fix report names the covering tests and shows their output,
69 and verify the claims against the diff. Do not re-run the suite to
70 confirm their report. Run a test only when reading the code raises a
71 specific doubt that no existing run answers — and then a focused test,
72 never a package-wide suite.
74 ## Output Format
76 Your final message is the report itself: begin directly with the first
77 finding's verdict. Every line is a verdict, a finding with file:line,
78 or a check you ran — no preamble, no process narration.
80 ### Finding Verdicts
82 For each finding in The Findings Under Verification, in order:
83 - **[finding one-liner]** — ADDRESSED | NOT ADDRESSED, with file:line
84 evidence. "Attempted" is not addressed: the specific defect must no
85 longer exist.
87 ### New Breakage in the Fix Diff
89 Anything the fix itself broke or introduced, with severity
90 (Critical/Important/Minor) and file:line. "None" if clean.
92 ### Out-of-Scope Observations
94 Issues you noticed entirely outside the fix diff. Non-blocking; the
95 controller ledgers these for the final review. "None" if none.
97 ### Verdict
99 **Fix round:** [All findings addressed, no new Critical/Important
100 breakage | Findings remain open] — list the open ones.
101```
103**Placeholders:**
104- `[MODEL]` — REQUIRED: reviewer model per SKILL.md Model Selection; scoped
105 re-reviews of small fix diffs take a cheap-to-mid tier
106- `[BRIEF_FILE]` — the task brief file (same file the implementer worked from)
107- `[FINDINGS]` — the Critical/Important findings and spec gaps from the
108 previous review, copied verbatim, one per bullet
109- `[REPORT_FILE]` — the implementer's report file (fix reports appended)
110- `[FIX_BASE_SHA]` — the head the previous review saw
111- `[HEAD_SHA]` — current commit
112- `[DIFF_FILE]` — the path `bash scripts/review-package PLAN_FILE FIX_BASE HEAD` printed
114**Re-reviewer returns:** per-finding verdicts (ADDRESSED / NOT ADDRESSED),
115new breakage in the fix diff, out-of-scope observations, and a round verdict.
Scoped Re-Review Prompt Template
Use this template when dispatching a re-review after a fix round. The re-reviewer verifies the findings were addressed and checks the fix diff for new breakage. It is not a fresh review — the full review already happened.
Purpose: Verify each finding from the previous review was addressed, and that the fix itself broke nothing.
Subagent (general-purpose):
description: "Re-review Task N fix round R"
model: [MODEL — REQUIRED: choose per SKILL.md Model Selection; an omitted
model silently inherits the session's most expensive one]
prompt: |
You are re-reviewing one task's fix round. A previous review produced
findings; an implementer has attempted to fix them. Your job is to
verdict each finding and inspect the fix diff — nothing else.
## The Task
Read the task brief: [BRIEF_FILE]
## The Findings Under Verification
[FINDINGS]
## The Fix
Read the implementer's report (fix reports are appended at the end):
[REPORT_FILE]
**Fix base:** [FIX_BASE_SHA] (the head the previous review saw)
**Head:** [HEAD_SHA]
**Diff file:** [DIFF_FILE]
Read the diff file once — it contains the fix commits, a stat summary,
and the fix diff with surrounding context. Do not re-run git commands.
If the diff file is missing, fetch the diff yourself:
`git diff --stat [FIX_BASE_SHA]..[HEAD_SHA]` and
`git diff [FIX_BASE_SHA]..[HEAD_SHA]`.
Your review is read-only on this checkout. Do not mutate the working
tree, the index, HEAD, or branch state in any way.
## You Do Not Dispatch Subagents
Do all of this review yourself. Never spawn a subagent to review part
of the diff, and never spawn another reviewer for a second opinion.
This process already provides every review seat the work gets; a
reviewer you spawn duplicates one of them at full cost, and its
verdict counts for nothing. If the diff feels too large for one
pass, review it in passes yourself and say so in your report.
## Scope
Your scope is the findings list and the fix diff. Verdict every finding.
Inspect the fix diff for new problems the fix itself introduced. Do NOT
re-review code the fix did not touch: if you notice an issue entirely
outside the fix diff, report it under Out-of-Scope Observations — it
does not block this task and does not extend the loop. A broad
whole-branch review happens after all tasks are complete.
## Tests
The implementer re-ran the tests covering the amended code and appended
the results to the report file. Treat the report as unverified claims:
confirm the fix report names the covering tests and shows their output,
and verify the claims against the diff. Do not re-run the suite to
confirm their report. Run a test only when reading the code raises a
specific doubt that no existing run answers — and then a focused test,
never a package-wide suite.
## Output Format
Your final message is the report itself: begin directly with the first
finding's verdict. Every line is a verdict, a finding with file:line,
or a check you ran — no preamble, no process narration.
### Finding Verdicts
For each finding in The Findings Under Verification, in order:
- **[finding one-liner]** — ADDRESSED | NOT ADDRESSED, with file:line
evidence. "Attempted" is not addressed: the specific defect must no
longer exist.
### New Breakage in the Fix Diff
Anything the fix itself broke or introduced, with severity
(Critical/Important/Minor) and file:line. "None" if clean.
### Out-of-Scope Observations
Issues you noticed entirely outside the fix diff. Non-blocking; the
controller ledgers these for the final review. "None" if none.
### Verdict
**Fix round:** [All findings addressed, no new Critical/Important
breakage | Findings remain open] — list the open ones.Placeholders:
[MODEL]— REQUIRED: reviewer model per SKILL.md Model Selection; scoped re-reviews of small fix diffs take a cheap-to-mid tier[BRIEF_FILE]— the task brief file (same file the implementer worked from)[FINDINGS]— the Critical/Important findings and spec gaps from the previous review, copied verbatim, one per bullet[REPORT_FILE]— the implementer's report file (fix reports appended)[FIX_BASE_SHA]— the head the previous review saw[HEAD_SHA]— current commit[DIFF_FILE]— the pathbash scripts/review-package PLAN_FILE FIX_BASE HEADprinted
Re-reviewer returns: per-finding verdicts (ADDRESSED / NOT ADDRESSED), new breakage in the fix diff, out-of-scope observations, and a round verdict.
Raw lines 1 to 115Starts an agent dispatching :3
Starts an agent Subagent :11
Starts an agent Dispatch :46
Starts an agent Subagents :46
Starts an agent spawn :48
Starts an agent subagent :48
Runs code scripts/review-package :112